Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 333403004: Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Oilpan: Trace CSSFontFaceSrcValue::m_svgFontFaceElement. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Source/core/css/CSSFontFaceSrcValue.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-17 00:58:09 UTC) #1
kouhei (in TOK)
lgtm
6 years, 6 months ago (2014-06-17 01:03:15 UTC) #2
haraken
LGTM
6 years, 6 months ago (2014-06-17 01:06:01 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-17 01:41:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/333403004/1
6 years, 6 months ago (2014-06-17 01:41:58 UTC) #5
commit-bot: I haz the power
Change committed as 176270
6 years, 6 months ago (2014-06-17 02:54:39 UTC) #6
kouhei (in TOK)
6 years, 6 months ago (2014-06-17 07:38:34 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/337703004/ by kouhei@chromium.org.

The reason for reverting is: This patch leaks svg-font-face-leak-document test

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40....

Powered by Google App Engine
This is Rietveld 408576698