Add a Clone method to ProofVerifyDetails to allow for the proof verify

net/quic/crypto/quic_crypto_client_config_test.cc

Index: net/quic/crypto/quic_crypto_client_config_test.cc
diff --git a/net/quic/crypto/quic_crypto_client_config_test.cc b/net/quic/crypto/quic_crypto_client_config_test.cc
index fdce91c1fc7a6566ebdbfd5500fee141b160e4f3..013c7c7916f8f71ee707809246582ef577872a6e 100644
--- a/net/quic/crypto/quic_crypto_client_config_test.cc
+++ b/net/quic/crypto/quic_crypto_client_config_test.cc
@@ -16,6 +16,14 @@ using std::vector;
 namespace net {
 namespace test {
 
+class TestProofVerifyDetails : public ProofVerifyDetails {

[wtc, 2014/07/29 01:48:24]

Nit: we probably should nest this inside an unnamed namespace.

[Ryan Hamilton, 2014/07/29 17:04:50]

Done.

+  virtual ~TestProofVerifyDetails() {}
+
+  virtual ProofVerifyDetails* Clone() const OVERRIDE {

[wtc, 2014/07/29 01:48:24]

Nit: should we add a "ProofVerifyDetails interface" comment?

[Ryan Hamilton, 2014/07/29 17:04:50]

Done.

+    return NULL;

[wtc, 2014/07/29 01:48:24]

BUG: this should return new TestProofVerifyDetails.

[Ryan Hamilton, 2014/07/29 17:04:50]

Done.

+  }
+};
+
 TEST(QuicCryptoClientConfigTest, CachedState_IsEmpty) {
   QuicCryptoClientConfig::CachedState state;
   EXPECT_TRUE(state.IsEmpty());
@@ -36,7 +44,7 @@ TEST(QuicCryptoClientConfigTest, CachedState_GenerationCounter) {
 TEST(QuicCryptoClientConfigTest, CachedState_SetProofVerifyDetails) {
   QuicCryptoClientConfig::CachedState state;
   EXPECT_TRUE(state.proof_verify_details() == NULL);
-  ProofVerifyDetails* details = new ProofVerifyDetails;
+  ProofVerifyDetails* details = new TestProofVerifyDetails;
   state.SetProofVerifyDetails(details);
   EXPECT_EQ(details, state.proof_verify_details());
 }