Add a Clone method to ProofVerifyDetails to allow for the proof verify

net/quic/crypto/quic_crypto_client_config_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/quic_crypto_client_config.h"
 
 #include "net/quic/crypto/proof_verifier.h"
 #include "net/quic/quic_server_id.h"
 #include "net/quic/test_tools/mock_random.h"
 #include "net/quic/test_tools/quic_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using std::string;
 using std::vector;
 
 namespace net {
 namespace test {
 
+class TestProofVerifyDetails : public ProofVerifyDetails {

[wtc, 2014/07/29 01:48:24]

Nit: we probably should nest this inside an unnamed namespace.

[Ryan Hamilton, 2014/07/29 17:04:50]

Done.

+  virtual ~TestProofVerifyDetails() {}
+
+  virtual ProofVerifyDetails* Clone() const OVERRIDE {

[wtc, 2014/07/29 01:48:24]

Nit: should we add a "ProofVerifyDetails interface" comment?

[Ryan Hamilton, 2014/07/29 17:04:50]

Done.

+    return NULL;

[wtc, 2014/07/29 01:48:24]

BUG: this should return new TestProofVerifyDetails.

[Ryan Hamilton, 2014/07/29 17:04:50]

Done.

+  }
+};
+
 TEST(QuicCryptoClientConfigTest, CachedState_IsEmpty) {
   QuicCryptoClientConfig::CachedState state;
   EXPECT_TRUE(state.IsEmpty());
 }
 
 TEST(QuicCryptoClientConfigTest, CachedState_IsComplete) {
   QuicCryptoClientConfig::CachedState state;
   EXPECT_FALSE(state.IsComplete(QuicWallTime::FromUNIXSeconds(0)));
 }
 
 TEST(QuicCryptoClientConfigTest, CachedState_GenerationCounter) {
   QuicCryptoClientConfig::CachedState state;
   EXPECT_EQ(0u, state.generation_counter());
   state.SetProofInvalid();
   EXPECT_EQ(1u, state.generation_counter());
 }
 
 TEST(QuicCryptoClientConfigTest, CachedState_SetProofVerifyDetails) {
   QuicCryptoClientConfig::CachedState state;
   EXPECT_TRUE(state.proof_verify_details() == NULL);
-  ProofVerifyDetails* details = new ProofVerifyDetails;
+  ProofVerifyDetails* details = new TestProofVerifyDetails;
   state.SetProofVerifyDetails(details);
   EXPECT_EQ(details, state.proof_verify_details());
 }
 
 TEST(QuicCryptoClientConfigTest, CachedState_InitializeFrom) {
   QuicCryptoClientConfig::CachedState state;
   QuicCryptoClientConfig::CachedState other;
   state.set_source_address_token("TOKEN");
   // TODO(rch): Populate other fields of |state|.
   other.InitializeFrom(state);
@@ skipping 200 matching lines @@
   EXPECT_EQ(state, cleared_cache);
   EXPECT_FALSE(cleared_cache->proof_valid());
   EXPECT_TRUE(cleared_cache->server_config().empty());
   EXPECT_TRUE(cleared_cache->certs().empty());
   EXPECT_TRUE(cleared_cache->signature().empty());
   EXPECT_EQ(2u, cleared_cache->generation_counter());
 }
 
 }  // namespace test
 }  // namespace net