net/quic/crypto/proof_verifier_chromium.cc - Issue 422623004: Add a Clone method to ProofVerifyDetails to allow for the proof verify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/proof_verifier_chromium.cc

Issue 422623004: Add a Clone method to ProofVerifyDetails to allow for the proof verify (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/quic/crypto/proof_verifier_chromium.h ('K') | « net/quic/crypto/proof_verifier_chromium.h ('k') | net/quic/crypto/quic_crypto_client_config.cc » ('j') | net/quic/crypto/quic_crypto_client_config_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/crypto/proof_verifier_chromium.cc

diff --git a/net/quic/crypto/proof_verifier_chromium.cc b/net/quic/crypto/proof_verifier_chromium.cc

index 43cd52bacf986153f4efef483192d64a99a4ed9c..60f893174938cc204265775cb44b657f17e1c8c9 100644

--- a/net/quic/crypto/proof_verifier_chromium.cc

+++ b/net/quic/crypto/proof_verifier_chromium.cc

@@ -31,6 +31,12 @@ using std::vector;

namespace net {

+ProofVerifyDetails* ProofVerifyDetailsChromium::Clone() const {

+ ProofVerifyDetailsChromium* other = new ProofVerifyDetailsChromium;

+ other->cert_verify_result.CopyFrom(cert_verify_result);

wtc 2014/07/29 01:48:24 I wonder why we don't just do other->cert_verif

Ryan Hamilton 2014/07/29 17:04:50 Done. I wonder why it has a CopyFrom method?

+ return NULL;

wtc 2014/07/29 01:48:24 BUG: return other; You owe me a lunch :-)

Ryan Hamilton 2014/07/29 17:04:50 Done. (I had not yet verified the fix :>)

// A Job handles the verification of a single proof. It is owned by the

// ProofVerifier. If the verification can not complete synchronously, it

// will notify the ProofVerifier upon completion.