Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422323002: Some fixes around GrContext::abandonContext: (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@abandon
Visibility:
Public.

Description

Some fixes around GrContext::abandonContext: Fix debug crash when GrResourceCache is destroyed after GrContext is abandoned while GrTextures are in the exlusive list. Notify debug GL context that GL resources are expected to remain undeleted when context is destroyed after being abandoned. Stop leaking program cache entries when context is abandoned. Committed: https://skia.googlesource.com/skia/+/944bcf0acb78f8f9da01e991f1307629959e338a

Patch Set 1 #

Total comments: 1

Patch Set 2 : update comment #

Patch Set 3 : fix typo #

Total comments: 7

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -10 lines) Patch
M include/gpu/GrContextFactory.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/gl/SkDebugGLContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M include/gpu/gl/SkGLContextHelper.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrTexture.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/SkGLContextHelper.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrDebugGL.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrDebugGL.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/SkDebugGLContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
https://codereview.chromium.org/422323002/diff/1/include/gpu/gl/SkGLContextHelper.h File include/gpu/gl/SkGLContextHelper.h (right): https://codereview.chromium.org/422323002/diff/1/include/gpu/gl/SkGLContextHelper.h#newcode57 include/gpu/gl/SkGLContextHelper.h:57: * context to test that further GL calls are ...
6 years, 4 months ago (2014-07-29 14:18:13 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/422323002/diff/40001/include/gpu/GrContextFactory.h File include/gpu/GrContextFactory.h (right): https://codereview.chromium.org/422323002/diff/40001/include/gpu/GrContextFactory.h#newcode109 include/gpu/GrContextFactory.h:109: for (int i = 0; i ...
6 years, 4 months ago (2014-07-29 14:32:31 UTC) #2
bsalomon
https://codereview.chromium.org/422323002/diff/40001/include/gpu/GrContextFactory.h File include/gpu/GrContextFactory.h (right): https://codereview.chromium.org/422323002/diff/40001/include/gpu/GrContextFactory.h#newcode109 include/gpu/GrContextFactory.h:109: for (int i = 0; i < fContexts.count(); ++i) ...
6 years, 4 months ago (2014-07-29 14:43:15 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-07-29 14:43:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/422323002/60001
6 years, 4 months ago (2014-07-29 14:44:01 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 15:01:58 UTC) #6
Message was sent while issue was closed. 
Change committed as 944bcf0acb78f8f9da01e991f1307629959e338a

Powered by Google App Engine
This is Rietveld 408576698