Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Unified Diff: Source/core/svg/SVGElement.cpp

Issue 421863002: SVGElement::parseAttribute resolves property via property map (Step 1) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add OVERRIDE keywords Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGElement.cpp
diff --git a/Source/core/svg/SVGElement.cpp b/Source/core/svg/SVGElement.cpp
index 1e1ef4c08fe945a52b55c3351cbf7333fe4d71e8..3ec3d7ae6fb07a596df1e452a0eefcc3f91e0da8 100644
--- a/Source/core/svg/SVGElement.cpp
+++ b/Source/core/svg/SVGElement.cpp
@@ -602,6 +602,18 @@ void SVGElement::parseAttribute(const QualifiedName& name, const AtomicString& v
}
}
+void SVGElement::parseAttributeNew(const QualifiedName& name, const AtomicString& value)
+{
+ RefPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute(name);
+ if (property) {
+ SVGParsingError parseError = NoError;
+ property->setBaseValueAsString(value, parseError);
+ reportAttributeParsingError(parseError, name, value);
+ }
fs 2014/07/28 08:00:45 Should there be a 'return' here?
kouhei (in TOK) 2014/07/28 08:51:03 Yes. Thanks for the catch.
+
+ SVGElement::parseAttribute(name, value);
+}
+
typedef HashMap<QualifiedName, AnimatedPropertyType> AttributeToPropertyTypeMap;
AnimatedPropertyType SVGElement::animatedPropertyTypeForCSSAttribute(const QualifiedName& attributeName)
{

Powered by Google App Engine
This is Rietveld 408576698