SVGElement::parseAttribute resolves property via property map (Step 1)

Source/core/svg/SVGRectElement.cpp

Index: Source/core/svg/SVGRectElement.cpp
diff --git a/Source/core/svg/SVGRectElement.cpp b/Source/core/svg/SVGRectElement.cpp
index 66fdbe809fa382b1d315062345055e5b4f4ec85a..c141e9233a1e26d9199d1ce457bd72732c682b98 100644
--- a/Source/core/svg/SVGRectElement.cpp
+++ b/Source/core/svg/SVGRectElement.cpp
@@ -65,26 +65,7 @@ bool SVGRectElement::isSupportedAttribute(const QualifiedName& attrName)
 
 void SVGRectElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
-    SVGParsingError parseError = NoError;
-
-    if (!isSupportedAttribute(name))

[haraken, 2014/07/28 04:49:13]

Just help me understand: How is isSupportedAttribute(name) handled in the
parseAttributeNew()?

[kouhei (in TOK), 2014/07/28 04:51:29]

IIUC, isSupportedAttribute() is an optimization to avoid the if chains if the
property is not in the HashSet. We do not need it anymore as we are replacing it
with a single HashMap lookup in SVGElement::parseAttributeNew

-        SVGGeometryElement::parseAttribute(name, value);
-    else if (name == SVGNames::xAttr)
-        m_x->setBaseValueAsString(value, parseError);
-    else if (name == SVGNames::yAttr)
-        m_y->setBaseValueAsString(value, parseError);
-    else if (name == SVGNames::rxAttr)
-        m_rx->setBaseValueAsString(value, parseError);
-    else if (name == SVGNames::ryAttr)
-        m_ry->setBaseValueAsString(value, parseError);
-    else if (name == SVGNames::widthAttr)
-        m_width->setBaseValueAsString(value, parseError);
-    else if (name == SVGNames::heightAttr)
-        m_height->setBaseValueAsString(value, parseError);
-    else
-        ASSERT_NOT_REACHED();
-
-    reportAttributeParsingError(parseError, name, value);
+    parseAttributeNew(name, value);
 }
 
 void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)