SVGElement::parseAttribute resolves property via property map (Step 1)

Source/core/svg/SVGElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 584 matching lines @@
     } else {
         // standard events
         const AtomicString& eventName = HTMLElement::eventNameForAttributeName(name);
         if (!eventName.isNull())
             setAttributeEventListener(eventName, createAttributeEventListener(this, name, value, eventParameterName()));
         else
             Element::parseAttribute(name, value);
     }
 }
 
+void SVGElement::parseAttributeNew(const QualifiedName& name, const AtomicString& value)
+{
+    RefPtr<SVGAnimatedPropertyBase> property = propertyFromAttribute(name);
+    if (property) {
+        SVGParsingError parseError = NoError;
+        property->setBaseValueAsString(value, parseError);
+        reportAttributeParsingError(parseError, name, value);
+    }

[fs, 2014/07/28 08:00:45]

Should there be a 'return' here?

[kouhei (in TOK), 2014/07/28 08:51:03]

Yes. Thanks for the catch.

+
+    SVGElement::parseAttribute(name, value);
+}
+
 typedef HashMap<QualifiedName, AnimatedPropertyType> AttributeToPropertyTypeMap;
 AnimatedPropertyType SVGElement::animatedPropertyTypeForCSSAttribute(const QualifiedName& attributeName)
 {
     DEFINE_STATIC_LOCAL(AttributeToPropertyTypeMap, cssPropertyMap, ());
 
     if (cssPropertyMap.isEmpty()) {
         // Fill the map for the first use.
         cssPropertyMap.set(alignment_baselineAttr, AnimatedString);
         cssPropertyMap.set(baseline_shiftAttr, AnimatedString);
         cssPropertyMap.set(buffered_renderingAttr, AnimatedString);
@@ skipping 552 matching lines @@
     Element::trace(visitor);
 }
 
 const AtomicString& SVGElement::eventParameterName()
 {
     DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::ConstructFromLiteral));
     return evtString;
 }
 
 }