Issue 421843004: Revert 285479 "Make DataSource::Stop() synchronous."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421843004: Revert 285479 "Make DataSource::Stop() synchronous." (Closed)

Created:
6 years, 4 months ago by aarya

Modified:
6 years, 4 months ago

Reviewers:
xhwang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 285479 "Make DataSource::Stop() synchronous." Causing UAFs on ClusterFuzz BUG=397656 > Make DataSource::Stop() synchronous. > > In a lot of filters in media code, Stop() has been folded into the dtor. > This model doesn't apply directly to DataSource because DataSource::Stop() > is called by the FFmpegDemuxer, but the DataSource is owned by > WebMediaPlayerImpl. > > TBR=gbillock@chromium.org > BUG=349211 > TEST=All existing tests pass. > > Review URL: https://codereview.chromium.org/413243002 TBR=xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285858

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -30 lines)			Patch
M	trunk/src/chrome/utility/media_galleries/ipc_data_source.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/chrome/utility/media_galleries/ipc_data_source.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/renderer/media/buffered_data_source.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/renderer/media/buffered_data_source.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/content/renderer/media/buffered_data_source_unittest.cc	View	3 chunks	+27 lines, -2 lines	0 comments	Download
M	trunk/src/media/base/data_source.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/filters/blocking_url_protocol_unittest.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	trunk/src/media/filters/ffmpeg_demuxer.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/media/filters/ffmpeg_demuxer.cc	View	2 chunks	+21 lines, -15 lines	0 comments	Download
M	trunk/src/media/filters/file_data_source.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/filters/file_data_source.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/media/filters/file_data_source_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/tools/player_x11/data_source_logger.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/tools/player_x11/data_source_logger.cc	View	2 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r285858.