Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: trunk/src/chrome/utility/media_galleries/ipc_data_source.cc

Issue 421843004: Revert 285479 "Make DataSource::Stop() synchronous." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/utility/media_galleries/ipc_data_source.h" 5 #include "chrome/utility/media_galleries/ipc_data_source.h"
6 6
7 #include "base/message_loop/message_loop_proxy.h" 7 #include "base/message_loop/message_loop_proxy.h"
8 #include "chrome/common/extensions/chrome_utility_extensions_messages.h" 8 #include "chrome/common/extensions/chrome_utility_extensions_messages.h"
9 #include "content/public/utility/utility_thread.h" 9 #include "content/public/utility/utility_thread.h"
10 10
11 namespace metadata { 11 namespace metadata {
12 12
13 IPCDataSource::IPCDataSource(int64 total_size) 13 IPCDataSource::IPCDataSource(int64 total_size)
14 : total_size_(total_size), 14 : total_size_(total_size),
15 utility_task_runner_(base::MessageLoopProxy::current()), 15 utility_task_runner_(base::MessageLoopProxy::current()),
16 next_request_id_(0) { 16 next_request_id_(0) {
17 data_source_thread_checker_.DetachFromThread(); 17 data_source_thread_checker_.DetachFromThread();
18 } 18 }
19 19
20 IPCDataSource::~IPCDataSource() { 20 IPCDataSource::~IPCDataSource() {
21 DCHECK(utility_thread_checker_.CalledOnValidThread()); 21 DCHECK(utility_thread_checker_.CalledOnValidThread());
22 } 22 }
23 23
24 void IPCDataSource::Stop() { 24 void IPCDataSource::Stop(const base::Closure& callback) {
25 DCHECK(data_source_thread_checker_.CalledOnValidThread()); 25 DCHECK(data_source_thread_checker_.CalledOnValidThread());
26 callback.Run();
26 } 27 }
27 28
28 void IPCDataSource::Read(int64 position, int size, uint8* data, 29 void IPCDataSource::Read(int64 position, int size, uint8* data,
29 const DataSource::ReadCB& read_cb) { 30 const DataSource::ReadCB& read_cb) {
30 DCHECK(data_source_thread_checker_.CalledOnValidThread()); 31 DCHECK(data_source_thread_checker_.CalledOnValidThread());
31 utility_task_runner_->PostTask( 32 utility_task_runner_->PostTask(
32 FROM_HERE, 33 FROM_HERE,
33 base::Bind(&IPCDataSource::ReadOnUtilityThread, base::Unretained(this), 34 base::Bind(&IPCDataSource::ReadOnUtilityThread, base::Unretained(this),
34 position, size, data, read_cb)); 35 position, size, data, read_cb));
35 } 36 }
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 if (it == pending_requests_.end()) 99 if (it == pending_requests_.end())
99 return; 100 return;
100 101
101 std::copy(bytes.begin(), bytes.end(), it->second.destination); 102 std::copy(bytes.begin(), bytes.end(), it->second.destination);
102 it->second.callback.Run(bytes.size()); 103 it->second.callback.Run(bytes.size());
103 104
104 pending_requests_.erase(it); 105 pending_requests_.erase(it);
105 } 106 }
106 107
107 } // namespace metadata 108 } // namespace metadata
OLDNEW
« no previous file with comments | « trunk/src/chrome/utility/media_galleries/ipc_data_source.h ('k') | trunk/src/content/renderer/media/buffered_data_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698