Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 413243002: Make DataSource::Stop() synchronous. (Closed)

Created:
6 years, 5 months ago by xhwang
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make DataSource::Stop() synchronous. In a lot of filters in media code, Stop() has been folded into the dtor. This model doesn't apply directly to DataSource because DataSource::Stop() is called by the FFmpegDemuxer, but the DataSource is owned by WebMediaPlayerImpl. TBR=gbillock@chromium.org BUG=349211 TEST=All existing tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285479

Patch Set 1 #

Patch Set 2 : fix BufferedDataSourceTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -75 lines) Patch
M chrome/utility/media_galleries/ipc_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/media_galleries/ipc_data_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/buffered_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/buffered_data_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/buffered_data_source_unittest.cc View 1 3 chunks +2 lines, -27 lines 0 comments Download
M media/base/data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/blocking_url_protocol_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +15 lines, -21 lines 0 comments Download
M media/filters/file_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/filters/file_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/data_source_logger.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/data_source_logger.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
xhwang
Here's another one. PTAL.
6 years, 5 months ago (2014-07-24 20:03:26 UTC) #1
scherkus (not reviewing)
lgtm
6 years, 5 months ago (2014-07-24 22:20:59 UTC) #2
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 5 months ago (2014-07-24 22:29:26 UTC) #3
xhwang
The CQ bit was unchecked by xhwang@chromium.org
6 years, 5 months ago (2014-07-24 22:29:30 UTC) #4
xhwang
TBRing gbillock@chromium.org for changes in chrome/utility/media_galleries/*
6 years, 5 months ago (2014-07-24 22:30:57 UTC) #5
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 5 months ago (2014-07-24 22:31:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/413243002/20001
6 years, 5 months ago (2014-07-24 22:33:52 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 00:13:59 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 04:36:55 UTC) #9
Message was sent while issue was closed.
Change committed as 285479

Powered by Google App Engine
This is Rietveld 408576698