Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 421693003: Stop using controller as a variable name for FullscreenElementStack (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-rendering, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Stop using controller as a variable name for FullscreenElementStack This was probably originally FullscreenController. Also fix a typo and simplify isActiveFullScreenElement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179009

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/core/dom/FullscreenElementStack.h View 1 chunk +3 lines, -3 lines 2 comments Download
M Source/core/rendering/RenderFullScreen.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
6 years, 5 months ago (2014-07-25 22:26:19 UTC) #1
falken
lgtm. I like how the code keep getting simpler. https://codereview.chromium.org/421693003/diff/1/Source/core/dom/FullscreenElementStack.h File Source/core/dom/FullscreenElementStack.h (right): https://codereview.chromium.org/421693003/diff/1/Source/core/dom/FullscreenElementStack.h#newcode130 Source/core/dom/FullscreenElementStack.h:130: ...
6 years, 4 months ago (2014-07-28 02:10:48 UTC) #2
philipj_slow
https://codereview.chromium.org/421693003/diff/1/Source/core/dom/FullscreenElementStack.h File Source/core/dom/FullscreenElementStack.h (right): https://codereview.chromium.org/421693003/diff/1/Source/core/dom/FullscreenElementStack.h#newcode130 Source/core/dom/FullscreenElementStack.h:130: return fullscreen->webkitCurrentFullScreenElement() == &element; On 2014/07/28 02:10:48, falken wrote: ...
6 years, 4 months ago (2014-07-28 07:47:10 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-28 07:47:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/421693003/1
6 years, 4 months ago (2014-07-28 07:47:50 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 08:17:21 UTC) #6
Message was sent while issue was closed.
Change committed as 179009

Powered by Google App Engine
This is Rietveld 408576698