Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: Source/core/dom/FullscreenElementStack.h

Issue 421693003: Stop using controller as a variable name for FullscreenElementStack (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/rendering/RenderFullScreen.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/FullscreenElementStack.h
diff --git a/Source/core/dom/FullscreenElementStack.h b/Source/core/dom/FullscreenElementStack.h
index cf7c43487ca665f3b661df79834020b976e75695..8cff235ca0b1738a36bf5b2db3fc36a95c818d66 100644
--- a/Source/core/dom/FullscreenElementStack.h
+++ b/Source/core/dom/FullscreenElementStack.h
@@ -124,10 +124,10 @@ private:
inline bool FullscreenElementStack::isActiveFullScreenElement(const Element& element)
{
- FullscreenElementStack* controller = fromIfExists(element.document());
- if (!controller)
+ FullscreenElementStack* fullscreen = fromIfExists(element.document());
+ if (!fullscreen)
return false;
- return controller->webkitIsFullScreen() && controller->webkitCurrentFullScreenElement() == element;
+ return fullscreen->webkitCurrentFullScreenElement() == &element;
falken 2014/07/28 02:10:48 I don't get how this worked before, webkitCurrentF
philipj_slow 2014/07/28 07:47:10 That worked because of the DEFINE_COMPARISON_OPERA
}
inline FullscreenElementStack* FullscreenElementStack::fromIfExists(Document& document)
« no previous file with comments | « no previous file | Source/core/rendering/RenderFullScreen.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698