Stop using controller as a variable name for FullscreenElementStack

Source/core/dom/FullscreenElementStack.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
@@ skipping 106 matching lines @@
     WillBeHeapVector<RefPtrWillBeMember<Element> > m_fullScreenElementStack;
     RenderFullScreen* m_fullScreenRenderer;
     Timer<FullscreenElementStack> m_eventQueueTimer;
     WillBeHeapDeque<RefPtrWillBeMember<Event> > m_eventQueue;
     LayoutRect m_savedPlaceholderFrameRect;
     RefPtr<RenderStyle> m_savedPlaceholderRenderStyle;
 };
 
 inline bool FullscreenElementStack::isActiveFullScreenElement(const Element& element)
 {
-    FullscreenElementStack* controller = fromIfExists(element.document());
-    if (!controller)
+    FullscreenElementStack* fullscreen = fromIfExists(element.document());
+    if (!fullscreen)
         return false;
-    return controller->webkitIsFullScreen() && controller->webkitCurrentFullScreenElement() == element;
+    return fullscreen->webkitCurrentFullScreenElement() == &element;

[falken, 2014/07/28 02:10:48]

I don't get how this worked before, webkitCurrentFullScreenElement() returns a
pointer yet we were comparing to a reference?

[philipj_slow, 2014/07/28 07:47:10]

That worked because of the
DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED macro, which was recently
discussed on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/6hUjMIIhesY/USLuqA1J...

I changed it for clarity, and in case that macro ends up being removed.

 }
 
 inline FullscreenElementStack* FullscreenElementStack::fromIfExists(Document& document)
 {
     if (!document.hasFullscreenElementStack())
         return 0;
     return fromIfExistsSlow(document);
 }
 
 } // namespace blink
 
 #endif // FullscreenElementStack_h