Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: test/generator-output/gyptest-actions.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Rebase onto origin/master Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/generator-output/gyptest-actions.py
diff --git a/test/generator-output/gyptest-actions.py b/test/generator-output/gyptest-actions.py
index 8c912e492b5afec87108fa3c6d4396eae5c35be6..d5723173d4427f69de16ace5cdd296644923b92e 100755
--- a/test/generator-output/gyptest-actions.py
+++ b/test/generator-output/gyptest-actions.py
@@ -13,6 +13,10 @@ import TestGyp
# Android doesn't support --generator-output.
test = TestGyp.TestGyp(formats=['!android'])
+# Bug: xcode-ninja doesn't respect --generator-output
sdefresne 2014/09/02 15:13:05 Please file a bug (if it does not exists) and add
Tobias 2014/10/02 18:19:19 This is the bug that triggered all of this ;) http
+if test.format == 'xcode-ninja':
+ test.skip_test()
+
# All the generated files should go under 'gypfiles'. The source directory
# ('actions') should be untouched.
test.writable(test.workpath('actions'), False)

Powered by Google App Engine
This is Rietveld 408576698