test/dependencies/gyptest-lib-only.py - Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/dependencies/gyptest-lib-only.py

Issue 421453003: Add TestGypXcodeNinja to run tests against the xcode-ninja generator (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Rebase onto origin/master Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« test/compiler-override/gyptest-compiler-global-settings.py ('K') | « test/dependencies/gyptest-extra-targets.py ('k') | test/generator-output/gyptest-actions.py » ('j') | test/generator-output/gyptest-actions.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/dependencies/gyptest-lib-only.py

diff --git a/test/dependencies/gyptest-lib-only.py b/test/dependencies/gyptest-lib-only.py

index 283c29ee0f17fc6b707d02e58f5996a07d8ff1b4..bf30ddb1fa952aaa9ed05ba63dad3c2c1a5c4c4d 100755

--- a/test/dependencies/gyptest-lib-only.py

+++ b/test/dependencies/gyptest-lib-only.py

@@ -15,7 +15,8 @@ import sys

test = TestGyp.TestGyp()

-test.run_gyp('lib_only.gyp')

+test.run_gyp('lib_only.gyp',

+ '-G', 'xcode_ninja_target_pattern=^.*$')

test.build('lib_only.gyp', test.ALL)

@@ -29,7 +30,7 @@ if sys.platform == 'darwin':

if test.format == 'xcode':

test.built_file_must_not_exist('b', type=test.STATIC_LIB)

else:

- assert test.format in ('make', 'ninja')

+ assert test.format in ('make', 'ninja', 'xcode-ninja')

test.built_file_must_exist('b', type=test.STATIC_LIB)

else:

# Make puts the resulting library in a directory matching the input gyp file;