Issue 421053005: Fix: xcode-ninja should generate Xcode workspace into generator_output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 421053005: Fix: xcode-ninja should generate Xcode workspace into generator_output (Closed)

Created:
6 years, 4 months ago by Tobias

Modified:
6 years ago

Reviewers:
sdefresne, justincohen

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-2

Visibility:
Public.

More Reviews

Description

Fix: xcode-ninja should generate Xcode workspace into generator_output The test gyptest-top-all guards against this when run using TestGypXcodeNinja, i.e. $ ./gyptest.py -f xcode-ninja test/generator-output/gyptest-top-all.py BUG=gyp:442 TEST=Run ./gyptest.py -f xcode-ninja test/generator-output/gyptest-top-all.py Expected to pass (instead of failing with Permission denied: 'prog1.ninja.xcworkspace') Patch by Tobias Hahn <tobias.hahn@ableton.com>;. R=justincohen@chromium.org, sdefresne@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=2018

Patch Set 1 #

Patch Set 2 : Rebase onto Issue 421453003 #

Patch Set 3 : Address sdefresne's feedback to #421453003 #

Patch Set 4 : Rebase onto origin/master #

Patch Set 5 : Rebase onto 421453003 #

Patch Set 6 : Rebase onto 421453003 #

Patch Set 7 : Rebase onto 421453003 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -42 lines)			Patch
M	pylib/gyp/xcode_ninja.py	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	test/generator-output/gyptest-actions.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/generator-output/gyptest-copies.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/generator-output/gyptest-mac-bundle.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/generator-output/gyptest-relocate.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/generator-output/gyptest-rules.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/generator-output/gyptest-subdir2-deep.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/generator-output/gyptest-symlink.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/generator-output/gyptest-top-all.py	View	1 2	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sdefresne

6 years ago (2014-12-23 16:17:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 (id:120001) manually as 2018 (presubmit successful).

Expand Messages | Collapse Messages