chrome/browser/ui/app_list/app_list_syncable_service.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_syncable_service.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/app_list/app_list_syncable_service.cc

diff --git a/chrome/browser/ui/app_list/app_list_syncable_service.cc b/chrome/browser/ui/app_list/app_list_syncable_service.cc

index 79d967fd67d4bc26543c7c2538ad7733c21d5588..a5c826c5756504d4041787ca7686d882d3510837 100644

--- a/chrome/browser/ui/app_list/app_list_syncable_service.cc

+++ b/chrome/browser/ui/app_list/app_list_syncable_service.cc

@@ -117,8 +117,12 @@ bool IsUnRemovableDefaultApp(const std::string& id) {

}

void UninstallExtension(ExtensionService* service, const std::string& id) {

- if (service && service->GetInstalledExtension(id))

- service->UninstallExtension(id, extensions::UNINSTALL_REASON_SYNC, NULL);

+ if (service && service->GetInstalledExtension(id)) {

+ service->UninstallExtension(id,

+ extensions::UNINSTALL_REASON_SYNC,

+ base::Bind(&base::DoNothing),

+ NULL);

+ }

}

bool GetAppListItemType(AppListItem* item,