chrome/browser/themes/theme_service_unittest.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_service_unittest.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/themes/theme_service_unittest.cc

diff --git a/chrome/browser/themes/theme_service_unittest.cc b/chrome/browser/themes/theme_service_unittest.cc

index e4823dc7724e8972a5e1aed89beda2b16c1e2e4c..8f370a319703832953e826cf56a56cff957f341c 100644

--- a/chrome/browser/themes/theme_service_unittest.cc

+++ b/chrome/browser/themes/theme_service_unittest.cc

@@ -120,8 +120,10 @@ TEST_F(ThemeServiceTest, ThemeInstallUninstall) {

EXPECT_EQ(extension_id, theme_service->GetThemeID());

// Now uninstall the extension, should revert to the default theme.

- service_->UninstallExtension(

- extension_id, extensions::UNINSTALL_REASON_FOR_TESTING, NULL);

+ service_->UninstallExtension(extension_id,

+ extensions::UNINSTALL_REASON_FOR_TESTING,

+ base::Bind(&base::DoNothing),

+ NULL);

EXPECT_TRUE(theme_service->UsingDefaultTheme());

}