Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7564)

Unified Diff: chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc
diff --git a/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc b/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc
index b40c382dd3344c014cfaf6986f519b148c48e443..87e57c9a8b6895716bc917390f415ea1432323e4 100644
--- a/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc
+++ b/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc
@@ -206,8 +206,10 @@ TEST_F(ExtensionAppModelBuilderTest, DisableAndEnable) {
}
TEST_F(ExtensionAppModelBuilderTest, Uninstall) {
- service_->UninstallExtension(
- kPackagedApp2Id, extensions::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(kPackagedApp2Id,
+ extensions::UNINSTALL_REASON_FOR_TESTING,
+ base::Bind(&base::DoNothing),
+ NULL);
EXPECT_EQ(std::string("Packaged App 1,Hosted App"),
GetModelContent(model_.get()));
@@ -222,8 +224,10 @@ TEST_F(ExtensionAppModelBuilderTest, UninstallTerminatedApp) {
// Simulate an app termination.
service_->TrackTerminatedExtensionForTest(app);
- service_->UninstallExtension(
- kPackagedApp2Id, extensions::UNINSTALL_REASON_FOR_TESTING, NULL);
+ service_->UninstallExtension(kPackagedApp2Id,
+ extensions::UNINSTALL_REASON_FOR_TESTING,
+ base::Bind(&base::DoNothing),
+ NULL);
EXPECT_EQ(std::string("Packaged App 1,Hosted App"),
GetModelContent(model_.get()));
« no previous file with comments | « chrome/browser/ui/app_list/app_list_syncable_service.cc ('k') | chrome/browser/ui/app_list/extension_uninstaller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698