chrome/browser/themes/theme_service.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_service.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/themes/theme_service.cc

diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc

index 7f589bd0b2d5392319e2f7aabc74fe0b51807913..a4a854d11c4908a7405c729210bc68675c04c070 100644

--- a/chrome/browser/themes/theme_service.cc

+++ b/chrome/browser/themes/theme_service.cc

@@ -372,8 +372,10 @@ void ThemeService::RemoveUnusedThemes(bool ignore_infobars) {

// policy provider.

for (size_t i = 0; i < remove_list.size(); ++i) {

- service->UninstallExtension(

- remove_list[i], extensions::UNINSTALL_REASON_ORPHANED_THEME, NULL);

+ service->UninstallExtension(remove_list[i],

+ extensions::UNINSTALL_REASON_ORPHANED_THEME,

+ base::Bind(&base::DoNothing),

+ NULL);

}