chrome/browser/search/hotword_service.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/hotword_service.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search/hotword_service.cc

diff --git a/chrome/browser/search/hotword_service.cc b/chrome/browser/search/hotword_service.cc

index 29b883d55d4293bc3fa789c8b26e57378b128f7d..d1d67a798c3bf313a857e6cd7afd868c4022aa2c 100644

--- a/chrome/browser/search/hotword_service.cc

+++ b/chrome/browser/search/hotword_service.cc

@@ -365,6 +365,7 @@ bool HotwordService::UninstallHotwordExtension(

if (!extension_service->UninstallExtension(

extension_misc::kHotwordExtensionId,

extensions::UNINSTALL_REASON_INTERNAL_MANAGEMENT,

+ base::Bind(&base::DoNothing),

&error)) {

LOG(WARNING) << "Cannot uninstall extension with id "

<< extension_misc::kHotwordExtensionId

« no previous file with comments | « chrome/browser/policy/policy_browsertest.cc ('k') | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »