Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
index eafd806ca4f4ed7e955c631ce19aeaf691852917..4f516bb196c3419f2168f68e20b9366a992d352b 100644
--- a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
+++ b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc
@@ -190,7 +190,10 @@ TEST_F(ActivityLogEnabledTest, WatchdogSwitch) {
EXPECT_FALSE(activity_log2->IsDatabaseEnabled());
extension_service1->UninstallExtension(
- kExtensionID, extensions::UNINSTALL_REASON_FOR_TESTING, NULL);
+ kExtensionID,
+ extensions::UNINSTALL_REASON_FOR_TESTING,
+ base::Bind(&base::DoNothing),
+ NULL);
EXPECT_EQ(0,
profile1->GetPrefs()->GetInteger(prefs::kWatchdogExtensionActive));
@@ -266,7 +269,10 @@ TEST_F(ActivityLogEnabledTest, AppAndCommandLine) {
EXPECT_TRUE(activity_log->IsWatchdogAppActive());
extension_service->UninstallExtension(
- kExtensionID, extensions::UNINSTALL_REASON_FOR_TESTING, NULL);
+ kExtensionID,
+ extensions::UNINSTALL_REASON_FOR_TESTING,
+ base::Bind(&base::DoNothing),
+ NULL);
EXPECT_TRUE(activity_log->IsDatabaseEnabled());
EXPECT_EQ(0,

Powered by Google App Engine
This is Rietveld 408576698