chrome/browser/extensions/api/management/management_api.cc - Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/management/management_api.cc

diff --git a/chrome/browser/extensions/api/management/management_api.cc b/chrome/browser/extensions/api/management/management_api.cc

index bad8b18742bad165488038d478f84fcdd362c2e8..7fe4b64e3383a7522e170e9e2c5654ccf2e4d489 100644

--- a/chrome/browser/extensions/api/management/management_api.cc

+++ b/chrome/browser/extensions/api/management/management_api.cc

@@ -652,7 +652,10 @@ void ManagementUninstallFunctionBase::Finish(bool should_uninstall) {

SendResponse(false);

} else {

bool success = service()->UninstallExtension(

- extension_id_, extensions::UNINSTALL_REASON_MANAGEMENT_API, NULL);

+ extension_id_,

+ extensions::UNINSTALL_REASON_MANAGEMENT_API,

+ base::Bind(&base::DoNothing),

+ NULL);

// TODO set error_ if !success

SendResponse(success);