Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use base::DoNothing for empty callbacks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/background/background_application_list_model_unittest.cc ('k') | chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
index dd9d52b3b0a0220ab99754edce98cfd29e407bb3..b50387dbbc93ccd68da9e1ed7bbdcefc0755af7f 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
@@ -161,11 +161,17 @@ class TestStoragePartition : public StoragePartition {
return NULL;
}
- virtual void ClearDataForOrigin(
- uint32 remove_mask,
- uint32 quota_storage_remove_mask,
- const GURL& storage_origin,
- net::URLRequestContextGetter* rq_context) OVERRIDE {}
+ virtual void ClearDataForOrigin(uint32 remove_mask,
+ uint32 quota_storage_remove_mask,
+ const GURL& storage_origin,
+ net::URLRequestContextGetter* rq_context,
+ const base::Closure& callback) OVERRIDE {
+ BrowserThread::PostTask(BrowserThread::UI,
+ FROM_HERE,
+ base::Bind(&TestStoragePartition::AsyncRunCallback,
+ base::Unretained(this),
+ callback));
+ }
virtual void ClearData(uint32 remove_mask,
uint32 quota_storage_remove_mask,
« no previous file with comments | « chrome/browser/background/background_application_list_model_unittest.cc ('k') | chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698