Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 421193002: Fix ExtensionServiceTest.ClearExtensionData flakiness (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: use base::DoNothing for empty callbacks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browsing_data/browsing_data_remover.h" 5 #include "chrome/browser/browsing_data/browsing_data_remover.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 virtual content::DOMStorageContext* GetDOMStorageContext() OVERRIDE { 154 virtual content::DOMStorageContext* GetDOMStorageContext() OVERRIDE {
155 return NULL; 155 return NULL;
156 } 156 }
157 virtual content::IndexedDBContext* GetIndexedDBContext() OVERRIDE { 157 virtual content::IndexedDBContext* GetIndexedDBContext() OVERRIDE {
158 return NULL; 158 return NULL;
159 } 159 }
160 virtual content::ServiceWorkerContext* GetServiceWorkerContext() OVERRIDE { 160 virtual content::ServiceWorkerContext* GetServiceWorkerContext() OVERRIDE {
161 return NULL; 161 return NULL;
162 } 162 }
163 163
164 virtual void ClearDataForOrigin( 164 virtual void ClearDataForOrigin(uint32 remove_mask,
165 uint32 remove_mask, 165 uint32 quota_storage_remove_mask,
166 uint32 quota_storage_remove_mask, 166 const GURL& storage_origin,
167 const GURL& storage_origin, 167 net::URLRequestContextGetter* rq_context,
168 net::URLRequestContextGetter* rq_context) OVERRIDE {} 168 const base::Closure& callback) OVERRIDE {
169 BrowserThread::PostTask(BrowserThread::UI,
170 FROM_HERE,
171 base::Bind(&TestStoragePartition::AsyncRunCallback,
172 base::Unretained(this),
173 callback));
174 }
169 175
170 virtual void ClearData(uint32 remove_mask, 176 virtual void ClearData(uint32 remove_mask,
171 uint32 quota_storage_remove_mask, 177 uint32 quota_storage_remove_mask,
172 const GURL& storage_origin, 178 const GURL& storage_origin,
173 const OriginMatcherFunction& origin_matcher, 179 const OriginMatcherFunction& origin_matcher,
174 const base::Time begin, 180 const base::Time begin,
175 const base::Time end, 181 const base::Time end,
176 const base::Closure& callback) OVERRIDE { 182 const base::Closure& callback) OVERRIDE {
177 // Store stuff to verify parameters' correctness later. 183 // Store stuff to verify parameters' correctness later.
178 storage_partition_removal_data_.remove_mask = remove_mask; 184 storage_partition_removal_data_.remove_mask = remove_mask;
(...skipping 1571 matching lines...) Expand 10 before | Expand all | Expand 10 after
1750 EXPECT_EQ(1u, tester.clear_count()); 1756 EXPECT_EQ(1u, tester.clear_count());
1751 EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode()); 1757 EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode());
1752 } 1758 }
1753 1759
1754 TEST_F(BrowsingDataRemoverTest, DomainReliability_NoMonitor) { 1760 TEST_F(BrowsingDataRemoverTest, DomainReliability_NoMonitor) {
1755 BlockUntilBrowsingDataRemoved( 1761 BlockUntilBrowsingDataRemoved(
1756 BrowsingDataRemover::EVERYTHING, 1762 BrowsingDataRemover::EVERYTHING,
1757 BrowsingDataRemover::REMOVE_HISTORY | 1763 BrowsingDataRemover::REMOVE_HISTORY |
1758 BrowsingDataRemover::REMOVE_COOKIES, false); 1764 BrowsingDataRemover::REMOVE_COOKIES, false);
1759 } 1765 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698