Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: test/generator-output/gyptest-symlink.py

Issue 421053005: Fix: xcode-ninja should generate Xcode workspace into generator_output (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-2
Patch Set: Rebase onto 421453003 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/generator-output/gyptest-subdir2-deep.py ('k') | test/generator-output/gyptest-top-all.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/generator-output/gyptest-symlink.py
diff --git a/test/generator-output/gyptest-symlink.py b/test/generator-output/gyptest-symlink.py
index 89bccab32c5e92901d4983491e0e3b903f9e5ac1..7390fcd37f15d0434618ea287fe608c643e5293a 100755
--- a/test/generator-output/gyptest-symlink.py
+++ b/test/generator-output/gyptest-symlink.py
@@ -18,11 +18,6 @@ test = TestGyp.TestGyp(formats=['!android'])
if not hasattr(os, 'symlink'):
test.skip_test('Missing os.symlink -- skipping test.\n')
-# Bug: xcode-ninja doesn't respect --generator-output
-# cf. https://code.google.com/p/gyp/issues/detail?id=442
-if test.format == 'xcode-ninja':
- test.skip_test()
-
test.writable(test.workpath('src'), False)
test.writable(test.workpath('src/subdir2/deeper/build'), True)
« no previous file with comments | « test/generator-output/gyptest-subdir2-deep.py ('k') | test/generator-output/gyptest-top-all.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698