test/generator-output/gyptest-mac-bundle.py - Issue 421053005: Fix: xcode-ninja should generate Xcode workspace into generator_output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/generator-output/gyptest-mac-bundle.py

Issue 421053005: Fix: xcode-ninja should generate Xcode workspace into generator_output (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-2

Patch Set: Rebase onto 421453003 Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/generator-output/gyptest-mac-bundle.py

diff --git a/test/generator-output/gyptest-mac-bundle.py b/test/generator-output/gyptest-mac-bundle.py

index 58f8c287ffc58e18b08a5d9a154c81a96942e03e..840e1ec81fe998ff3d4400354b3056478b438954 100644

--- a/test/generator-output/gyptest-mac-bundle.py

+++ b/test/generator-output/gyptest-mac-bundle.py

@@ -15,11 +15,6 @@ import sys

if sys.platform == 'darwin':

test = TestGyp.TestGyp(formats=[])

- # Bug: xcode-ninja doesn't respect --generator-output

- # cf. https://code.google.com/p/gyp/issues/detail?id=442

- if test.format == 'xcode-ninja':

- test.skip_test()

MAC_BUNDLE_DIR = 'mac-bundle'

GYPFILES_DIR = 'gypfiles'

test.writable(test.workpath(MAC_BUNDLE_DIR), False)

« no previous file with comments | « test/generator-output/gyptest-copies.py ('k') | test/generator-output/gyptest-relocate.py » ('j') | no next file with comments »