Issue 420663006: [chromedriver] Fix mouse button value map in WebDriver atoms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420663006: [chromedriver] Fix mouse button value map in WebDriver atoms. (Closed)

Created:
6 years, 4 months ago by samuong

Modified:
6 years, 4 months ago

Reviewers:
stgao

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[chromedriver] Fix mouse button value map in WebDriver atoms. BUG=chromedriver:868 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287196

Patch Set 1 #

Patch Set 2 : Do the same for mouseout events. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
	M	third_party/webdriver/atoms.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	third_party/webdriver/patch.diff	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

samuong

This should fix SelectElementHandlingTest.testShouldBeAbleToSelectMoreThanOneOptionFromASelectWhichAllowsMultipleChoices on our waterfall. I've tested it for Chrome stable (36.0.1985.125) and ...

6 years, 4 months ago (2014-08-01 22:57:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samuong@chromium.org/420663006/20001

6 years, 4 months ago (2014-08-02 00:13:35 UTC) #4

Message was sent while issue was closed.

Change committed as 287196

Expand Messages | Collapse Messages