Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: third_party/webdriver/patch.diff

Issue 420663006: [chromedriver] Fix mouse button value map in WebDriver atoms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do the same for mouseout events. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/webdriver/patch.diff
diff --git a/third_party/webdriver/patch.diff b/third_party/webdriver/patch.diff
index 92b5f966298cbfa214df91f3940ed7171056f38b..e24ff8a7a4c2694814276e8e773767549b2b816d 100644
--- a/third_party/webdriver/patch.diff
+++ b/third_party/webdriver/patch.diff
@@ -1,3 +1,27 @@
+diff --git a/javascript/atoms/mouse.js b/javascript/atoms/mouse.js
+index bed494b..d6c3be1 100644
+--- a/javascript/atoms/mouse.js
++++ b/javascript/atoms/mouse.js
+@@ -141,7 +141,7 @@ bot.Mouse.NO_BUTTON_VALUE_INDEX_ = 3;
+ * click/ mouseup/ mouseout/ mousemove contextmenu
+ * dblclick mousedown mouseover
+ * IE_DOC_PRE9 0 0 0 X 1 4 2 X 0 0 0 0 1 4 2 0 X X 0 X
+- * WEBKIT/IE9 0 1 2 X 0 1 2 X 0 1 2 0 0 1 2 0 X X 2 X
++ * WEBKIT/IE9 0 1 2 X 0 1 2 X 0 1 2 4 0 1 2 4 X X 2 X
+ * GECKO/OPERA 0 1 2 X 0 1 2 X 0 0 0 0 0 0 0 0 X X 2 X
+ * </pre>
+ * @private {!Object.<bot.events.EventType, !Array.<?number>>}
+@@ -161,8 +161,8 @@ bot.Mouse.MOUSE_BUTTON_VALUE_MAP_ = (function() {
+ buttonValueMap[bot.events.EventType.CLICK] = [0, 1, 2, null];
+ buttonValueMap[bot.events.EventType.CONTEXTMENU] = [null, null, 2, null];
+ buttonValueMap[bot.events.EventType.MOUSEUP] = [0, 1, 2, null];
+- buttonValueMap[bot.events.EventType.MOUSEOUT] = [0, 1, 2, 0];
+- buttonValueMap[bot.events.EventType.MOUSEMOVE] = [0, 1, 2, 0];
++ buttonValueMap[bot.events.EventType.MOUSEOUT] = [0, 1, 2, 4];
++ buttonValueMap[bot.events.EventType.MOUSEMOVE] = [0, 1, 2, 4];
+ } else {
+ buttonValueMap[bot.events.EventType.CLICK] = [0, 1, 2, null];
+ buttonValueMap[bot.events.EventType.CONTEXTMENU] = [null, null, 2, null];
diff --git a/javascript/chrome-driver/build.desc b/javascript/chrome-driver/build.desc
index 356eefd..b0e6cae 100644
--- a/javascript/chrome-driver/build.desc
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698