Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: third_party/webdriver/patch.diff

Issue 420663006: [chromedriver] Fix mouse button value map in WebDriver atoms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do the same for mouseout events. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 diff --git a/javascript/atoms/mouse.js b/javascript/atoms/mouse.js
2 index bed494b..d6c3be1 100644
3 --- a/javascript/atoms/mouse.js
4 +++ b/javascript/atoms/mouse.js
5 @@ -141,7 +141,7 @@ bot.Mouse.NO_BUTTON_VALUE_INDEX_ = 3;
6 * click/ mouseup/ mouseout/ mousemove contextmenu
7 * dblclick mousedown mouseover
8 * IE_DOC_PRE9 0 0 0 X 1 4 2 X 0 0 0 0 1 4 2 0 X X 0 X
9 - * WEBKIT/IE9 0 1 2 X 0 1 2 X 0 1 2 0 0 1 2 0 X X 2 X
10 + * WEBKIT/IE9 0 1 2 X 0 1 2 X 0 1 2 4 0 1 2 4 X X 2 X
11 * GECKO/OPERA 0 1 2 X 0 1 2 X 0 0 0 0 0 0 0 0 X X 2 X
12 * </pre>
13 * @private {!Object.<bot.events.EventType, !Array.<?number>>}
14 @@ -161,8 +161,8 @@ bot.Mouse.MOUSE_BUTTON_VALUE_MAP_ = (function() {
15 buttonValueMap[bot.events.EventType.CLICK] = [0, 1, 2, null];
16 buttonValueMap[bot.events.EventType.CONTEXTMENU] = [null, null, 2, null];
17 buttonValueMap[bot.events.EventType.MOUSEUP] = [0, 1, 2, null];
18 - buttonValueMap[bot.events.EventType.MOUSEOUT] = [0, 1, 2, 0];
19 - buttonValueMap[bot.events.EventType.MOUSEMOVE] = [0, 1, 2, 0];
20 + buttonValueMap[bot.events.EventType.MOUSEOUT] = [0, 1, 2, 4];
21 + buttonValueMap[bot.events.EventType.MOUSEMOVE] = [0, 1, 2, 4];
22 } else {
23 buttonValueMap[bot.events.EventType.CLICK] = [0, 1, 2, null];
24 buttonValueMap[bot.events.EventType.CONTEXTMENU] = [null, null, 2, null];
1 diff --git a/javascript/chrome-driver/build.desc b/javascript/chrome-driver/buil d.desc 25 diff --git a/javascript/chrome-driver/build.desc b/javascript/chrome-driver/buil d.desc
2 index 356eefd..b0e6cae 100644 26 index 356eefd..b0e6cae 100644
3 --- a/javascript/chrome-driver/build.desc 27 --- a/javascript/chrome-driver/build.desc
4 +++ b/javascript/chrome-driver/build.desc 28 +++ b/javascript/chrome-driver/build.desc
5 @@ -24,6 +24,11 @@ js_fragment(name = "get_page_zoom", 29 @@ -24,6 +24,11 @@ js_fragment(name = "get_page_zoom",
6 function = "webdriver.chrome.getPageZoom", 30 function = "webdriver.chrome.getPageZoom",
7 deps = [ ":deps" ]) 31 deps = [ ":deps" ])
8 32
9 +js_fragment(name = "touch_single_tap", 33 +js_fragment(name = "touch_single_tap",
10 + module = "bot.action", 34 + module = "bot.action",
11 + function = "bot.action.tap", 35 + function = "bot.action.tap",
12 + deps = [ "//javascript/atoms:deps" ]) 36 + deps = [ "//javascript/atoms:deps" ])
13 + 37 +
14 js_test(name = "test", 38 js_test(name = "test",
15 srcs = [ "test/*_test.html" ], 39 srcs = [ "test/*_test.html" ],
16 deps = [ 40 deps = [
17 @@ -52,6 +57,7 @@ js_fragment_cpp(name = "atoms", 41 @@ -52,6 +57,7 @@ js_fragment_cpp(name = "atoms",
18 "//javascript/chrome-driver:get_location_in_view:chrome", 42 "//javascript/chrome-driver:get_location_in_view:chrome",
19 "//javascript/chrome-driver:get_page_zoom:chrome", 43 "//javascript/chrome-driver:get_page_zoom:chrome",
20 "//javascript/chrome-driver:is_element_clickable:chrome", 44 "//javascript/chrome-driver:is_element_clickable:chrome",
21 + "//javascript/chrome-driver:touch_single_tap:chrome", 45 + "//javascript/chrome-driver:touch_single_tap:chrome",
22 "//javascript/webdriver/atoms/fragments:clear_local_storage:chrome", 46 "//javascript/webdriver/atoms/fragments:clear_local_storage:chrome",
23 "//javascript/webdriver/atoms/fragments:clear_session_storage:chrome", 47 "//javascript/webdriver/atoms/fragments:clear_session_storage:chrome",
24 "//javascript/webdriver/atoms/fragments:get_appcache_status:chrome", 48 "//javascript/webdriver/atoms/fragments:get_appcache_status:chrome",
OLDNEW
« no previous file with comments | « third_party/webdriver/atoms.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698