net/quic/reliable_quic_stream_test.cc - Issue 420313005: Land Recent QUIC Changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 420313005: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0723

Patch Set: change QUIC packet size to 1350 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/quic/quic_received_packet_manager.h ('K') | « net/quic/reliable_quic_stream.cc ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | net/quic/test_tools/quic_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/reliable_quic_stream_test.cc

diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc

index ea81d6e34024fb27645ab5329536fce210afa565..f25011d5d307a6e2d1514338eaf64f542721e030 100644

--- a/net/quic/reliable_quic_stream_test.cc

+++ b/net/quic/reliable_quic_stream_test.cc

@@ -154,7 +154,7 @@ TEST_F(ReliableQuicStreamTest, WriteAllData) {

Initialize(kShouldProcessData);

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

- connection_->version(), PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

+ PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, NOT_IN_FEC_GROUP);

QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

length);

@@ -214,7 +214,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferData) {

EXPECT_FALSE(HasWriteBlockedStreams());

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

- connection_->version(), PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

+ PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, NOT_IN_FEC_GROUP);

QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

length);

@@ -249,7 +249,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataWithFecProtectAlways) {

EXPECT_FALSE(HasWriteBlockedStreams());

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

- connection_->version(), PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

+ PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, IN_FEC_GROUP);

QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

length);

@@ -285,7 +285,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataWithFecProtectOptional) {

EXPECT_FALSE(HasWriteBlockedStreams());

size_t length = 1 + QuicPacketCreator::StreamFramePacketOverhead(

- connection_->version(), PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

+ PACKET_8BYTE_CONNECTION_ID, !kIncludeVersion,

PACKET_6BYTE_SEQUENCE_NUMBER, 0u, NOT_IN_FEC_GROUP);

QuicConnectionPeer::GetPacketCreator(connection_)->set_max_packet_length(

length);

@@ -650,7 +650,7 @@ TEST_F(ReliableQuicStreamTest,

// Stream should not accept the frame, and the connection should be closed.

EXPECT_CALL(*connection_,

SendConnectionClose(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA));

- EXPECT_FALSE(stream_->OnStreamFrame(frame));

+ stream_->OnStreamFrame(frame);

}

TEST_F(ReliableQuicStreamTest, FinalByteOffsetFromFin) {

« net/quic/quic_received_packet_manager.h ('K') | « net/quic/reliable_quic_stream.cc ('k') | net/quic/test_tools/quic_connection_peer.h » ('j') | net/quic/test_tools/quic_test_utils.h » ('J')