net/quic/test_tools/quic_test_utils.h - Issue 420313005: Land Recent QUIC Changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/quic_test_utils.h

Issue 420313005: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0723

Patch Set: change QUIC packet size to 1350 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/test_tools/quic_test_utils.h

diff --git a/net/quic/test_tools/quic_test_utils.h b/net/quic/test_tools/quic_test_utils.h

index 3bae37f7d24f8694a0898aa877363670164362a8..350bc379151521513d1774da1d342ac24897d796 100644

--- a/net/quic/test_tools/quic_test_utils.h

+++ b/net/quic/test_tools/quic_test_utils.h

@@ -92,8 +92,7 @@ QuicVersionVector SupportedVersions(QuicVersion version);

// Testing convenience method to construct a QuicAckFrame with all packets

// from least_unacked to largest_observed acked.

wtc 2014/08/04 23:28:13 This comment needs updating because the "least_una

ramant (doing other things) 2014/08/09 02:53:19 Done.

-QuicAckFrame MakeAckFrame(QuicPacketSequenceNumber largest_observed,

- QuicPacketSequenceNumber least_unacked);

+QuicAckFrame MakeAckFrame(QuicPacketSequenceNumber largest_observed);

// Testing convenience method to construct a QuicAckFrame with |num_nack_ranges|

// nack ranges of width 1 packet, starting from |least_unacked|.