Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: net/quic/reliable_quic_stream.cc

Issue 420313005: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0723
Patch Set: change QUIC packet size to 1350 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/reliable_quic_stream.cc
diff --git a/net/quic/reliable_quic_stream.cc b/net/quic/reliable_quic_stream.cc
index 7785e72690ee26c065e1f4313dcdfe53e9cc5076..212b69868c7a8abe4df9d036c3afb6540ae4b57b 100644
--- a/net/quic/reliable_quic_stream.cc
+++ b/net/quic/reliable_quic_stream.cc
@@ -166,16 +166,16 @@ ReliableQuicStream::ReliableQuicStream(QuicStreamId id, QuicSession* session)
ReliableQuicStream::~ReliableQuicStream() {
}
-bool ReliableQuicStream::OnStreamFrame(const QuicStreamFrame& frame) {
+void ReliableQuicStream::OnStreamFrame(const QuicStreamFrame& frame) {
if (read_side_closed_) {
DVLOG(1) << ENDPOINT << "Ignoring frame " << frame.stream_id;
// We don't want to be reading: blackhole the data.
- return true;
+ return;
}
if (frame.stream_id != id_) {
- LOG(ERROR) << "Error!";
- return false;
+ session_->connection()->SendConnectionClose(QUIC_INTERNAL_ERROR);
+ return;
}
if (frame.fin) {
@@ -194,11 +194,11 @@ bool ReliableQuicStream::OnStreamFrame(const QuicStreamFrame& frame) {
connection_flow_controller_->FlowControlViolation()) {
session_->connection()->SendConnectionClose(
QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA);
- return false;
+ return;
}
}
- return sequencer_.OnStreamFrame(frame);
+ sequencer_.OnStreamFrame(frame);
}
int ReliableQuicStream::num_frames_received() const {

Powered by Google App Engine
This is Rietveld 408576698