Issue 418133002: Fix missing string resource for extensions_unittests on Chrome OS

Issue 418133002: Fix missing string resource for extensions_unittests on Chrome OS (Closed)

Created:
6 years, 5 months ago by James Cook

Modified:
6 years, 5 months ago

Reviewers:
tfarina, Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, oshima, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix missing string resource for extensions_unittests on Chrome OS Chrome OS requires app_locale_strings for font configuration information, so it needs to be part of the .pak file for extensions_unittests. BUG=397245 TEST=build extensions_unittests with chromeos=1, it doesn't crash on start Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285450

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	extensions/extensions.gyp	View		2 chunks	+7 lines, -0 lines	1 comment	Download
	M	extensions/shell/app_shell.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/418133002/1

6 years, 5 months ago (2014-07-24 21:59:05 UTC) #4

tfarina

https://codereview.chromium.org/418133002/diff/1/extensions/extensions.gyp File extensions/extensions.gyp (right): https://codereview.chromium.org/418133002/diff/1/extensions/extensions.gyp#newcode751 extensions/extensions.gyp:751: 'action_name': 'repack_extensions_unittests_pak', I have refactored this here -> https://codereview.chromium.org/413293003

6 years, 5 months ago (2014-07-24 22:41:33 UTC) #5

Message was sent while issue was closed.

Change committed as 285450

Expand Messages | Collapse Messages