Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 413293003: extensions: Create extensions_pak target. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Yoyo Zhou
Project:
chromium
Visibility:
Public.

Description

extensions: Create extensions_pak target. Currently this was just an action directly into extensions_unittests. But we want to share the same pak file between extensions_unittests and app_shell. So in order to do this we create a new target called "extensions_pak" and make extensions_unittests depend on it. After this lands, app_shell will be refactored to use extensions.pak too. BUG=397250 TEST=extensions_unittests R=jamescook@chromium.org TBR=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285597

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -25 lines) Patch
M extensions/extensions.gyp View 1 2 3 chunks +28 lines, -20 lines 0 comments Download
M extensions/test/extensions_unittests_main.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
James Cook
LGTM. I think you need a different bug number in the CL description. https://codereview.chromium.org/413293003/diff/20001/extensions/extensions.gyp File ...
6 years, 5 months ago (2014-07-24 23:25:12 UTC) #1
tfarina
Ops, thanks for catching the BUG number, I forgot the '0'. Updated. I will also ...
6 years, 5 months ago (2014-07-24 23:45:58 UTC) #2
James Cook
https://codereview.chromium.org/418133002/ just landed
6 years, 5 months ago (2014-07-25 02:41:58 UTC) #3
tfarina
Rebased. TBRing Yoyo for this.
6 years, 5 months ago (2014-07-25 13:38:54 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-25 13:38:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/413293003/40001
6 years, 5 months ago (2014-07-25 13:40:13 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 16:47:05 UTC) #7
Message was sent while issue was closed.
Change committed as 285597

Powered by Google App Engine
This is Rietveld 408576698