Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: extensions/extensions.gyp

Issue 418133002: Fix missing string resource for extensions_unittests on Chrome OS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/shell/app_shell.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/extensions.gyp
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
index 9bc93ae019efbdfae4a34e1fb7c58059052aa6a2..92db41fbeb3b455684e485cab501335e2e01b76c 100644
--- a/extensions/extensions.gyp
+++ b/extensions/extensions.gyp
@@ -703,6 +703,7 @@
'../content/content_shell_and_tests.gyp:test_support_content',
'../testing/gmock.gyp:gmock',
'../testing/gtest.gyp:gtest',
+ '../ui/strings/ui_strings.gyp:ui_strings',
'extensions_common',
'extensions_renderer',
'extensions_resources.gyp:extensions_resources',
@@ -743,11 +744,17 @@
],
'actions': [
{
+ # TODO(jamescook): Use the same .pak file for both app_shell and
+ # extensions_unittests by creating an extensions_resources.pak file
+ # that can be used in both places. This will save build time.
+ # http://crbug.com/397250
'action_name': 'repack_extensions_unittests_pak',
tfarina 2014/07/24 22:41:33 I have refactored this here -> https://codereview
'variables': {
'pak_inputs': [
'<(SHARED_INTERMEDIATE_DIR)/extensions/extensions_resources.pak',
'<(SHARED_INTERMEDIATE_DIR)/extensions/extensions_renderer_resources.pak',
+ '<(SHARED_INTERMEDIATE_DIR)/ui/strings/app_locale_settings_en-US.pak',
+ '<(SHARED_INTERMEDIATE_DIR)/ui/strings/ui_strings_en-US.pak',
],
'pak_output': '<(PRODUCT_DIR)/extensions_unittests_resources.pak',
},
« no previous file with comments | « no previous file | extensions/shell/app_shell.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698