Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 418073002: Alter Default & Software path renderers to better handle AA hairline paths (Closed)

Created:
6 years, 4 months ago by robertphillips
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Alter Default & Software path renderers to better handle AA hairline paths For some (as yet unknown reason) the guard in ConicPathBench that disables the path_hairline_big_AA_conic case isn't working. As an alternate fix, this CL makes the Default path renderer confess its lack of support for conics and allows the Software path renderer to handle non-AA cases. This will work but the real fix is to enable conics in the Default path renderer. Here is the situation we're seeing in the path_hairline_big_AA_conic case: the path is a hairline drawn with AA the render target is multisampled (so AA on the draw gets disabled) StencilAndCover path renderer doesn't handle hairlines AAHairLine path renderer only handles AA paths (but can handle conics) AAConvexPath renderer also only handles AA paths Default path renderer only handles non-AA paths (but doesn't handle conics) Software path renderer - was disallowed from handling non-AA paths BUG=skia:2078 Committed: https://skia.googlesource.com/skia/+/730c0447916909f01df7fa12e9c82dd7cf7989dc

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
https://codereview.chromium.org/418073002/diff/1/src/gpu/GrSoftwarePathRenderer.cpp File src/gpu/GrSoftwarePathRenderer.cpp (left): https://codereview.chromium.org/418073002/diff/1/src/gpu/GrSoftwarePathRenderer.cpp#oldcode18 src/gpu/GrSoftwarePathRenderer.cpp:18: if (!antiAlias || NULL == fContext) { Note that ...
6 years, 4 months ago (2014-07-24 17:18:59 UTC) #1
bsalomon
Do we setup the SkDraw to draw the path without aa?
6 years, 4 months ago (2014-07-24 17:57:21 UTC) #2
robertphillips
We set AA appropriately on the SkPaint we construct to draw the raster path.
6 years, 4 months ago (2014-07-24 18:27:38 UTC) #3
bsalomon
lgtm
6 years, 4 months ago (2014-07-24 18:57:15 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 4 months ago (2014-07-25 12:41:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/418073002/20001
6 years, 4 months ago (2014-07-25 12:42:07 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 12:52:43 UTC) #7
Message was sent while issue was closed.
Change committed as 730c0447916909f01df7fa12e9c82dd7cf7989dc

Powered by Google App Engine
This is Rietveld 408576698