Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 416993008: Introduce OutputFormatter interface and wire it through PageTestResults. (Closed)

Created:
6 years, 5 months ago by chrishenry
Modified:
6 years, 4 months ago
Reviewers:
nednguyen, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Introduce OutputFormatter interface and wire it through PageTestResults. Make --output-format=csv uses the new OutputFormatter instead of subclassing PageMeasurementResults. BUG=346956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285855

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Rebase, address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -244 lines) Patch
A + tools/telemetry/telemetry/results/csv_output_formatter.py View 1 2 chunks +31 lines, -28 lines 0 comments Download
A + tools/telemetry/telemetry/results/csv_output_formatter_unittest.py View 10 chunks +13 lines, -17 lines 0 comments Download
D tools/telemetry/telemetry/results/csv_page_measurement_results.py View 1 chunk +0 lines, -71 lines 0 comments Download
D tools/telemetry/telemetry/results/csv_page_measurement_results_unittest.py View 1 chunk +0 lines, -125 lines 0 comments Download
A tools/telemetry/telemetry/results/output_formatter.py View 1 chunk +33 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/results/page_test_results.py View 1 2 chunks +17 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/results/results_options.py View 1 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
chrishenry
6 years, 5 months ago (2014-07-25 23:32:19 UTC) #1
nednguyen
LGTM with nits https://codereview.chromium.org/416993008/diff/40001/tools/telemetry/telemetry/results/csv_output_formatter.py File tools/telemetry/telemetry/results/csv_output_formatter.py (right): https://codereview.chromium.org/416993008/diff/40001/tools/telemetry/telemetry/results/csv_output_formatter.py#newcode15 tools/telemetry/telemetry/results/csv_output_formatter.py:15: self._representative_value_names = None This doesn't need ...
6 years, 5 months ago (2014-07-26 15:44:33 UTC) #2
chrishenry
https://codereview.chromium.org/416993008/diff/40001/tools/telemetry/telemetry/results/csv_output_formatter.py File tools/telemetry/telemetry/results/csv_output_formatter.py (right): https://codereview.chromium.org/416993008/diff/40001/tools/telemetry/telemetry/results/csv_output_formatter.py#newcode15 tools/telemetry/telemetry/results/csv_output_formatter.py:15: self._representative_value_names = None On 2014/07/26 15:44:33, nednguyen wrote: > ...
6 years, 4 months ago (2014-07-27 20:34:54 UTC) #3
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 4 months ago (2014-07-27 20:34:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/416993008/60001
6 years, 4 months ago (2014-07-27 20:35:28 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 00:36:52 UTC) #6
Message was sent while issue was closed. 
Change committed as 285855

Powered by Google App Engine
This is Rietveld 408576698