Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: tools/telemetry/telemetry/results/page_test_results.py

Issue 416993008: Introduce OutputFormatter interface and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, address review comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/page_test_results.py
diff --git a/tools/telemetry/telemetry/results/page_test_results.py b/tools/telemetry/telemetry/results/page_test_results.py
index 8d960a2382e7c2134fc33e969666a2df869409e3..6b6c09acca861d817819be1b52ea2d89a03a90f5 100644
--- a/tools/telemetry/telemetry/results/page_test_results.py
+++ b/tools/telemetry/telemetry/results/page_test_results.py
@@ -11,9 +11,22 @@ from telemetry import value as value_module
from telemetry.value import failure
class PageTestResults(object):
- def __init__(self, output_stream=None, trace_tag=''):
+ def __init__(self, output_stream=None, output_formatters=None, trace_tag=''):
+ """
+ Args:
+ output_stream: The output stream to use to write test results.
+ output_formatters: A list of output formatters. The output
+ formatters are typically used to format the test results, such
+ as CsvOutputFormatter, which output the test results as CSV.
+ trace_tag: A string to append to the buildbot trace
+ name. Currently only used for buildbot.
+ """
+ # TODO(chrishenry): Figure out if trace_tag is still necessary.
+
super(PageTestResults, self).__init__()
self._output_stream = output_stream
+ self._output_formatters = (
+ output_formatters if output_formatters is not None else [])
self._trace_tag = trace_tag
self._current_page = None
@@ -97,6 +110,9 @@ class PageTestResults(object):
self.successes.append(page)
def PrintSummary(self):
+ for output_formatter in self._output_formatters:
+ output_formatter.Format(self)
+
if self.failures:
logging.error('Failed pages:\n%s', '\n'.join(
p.display_name for p in self.pages_that_had_failures))
« no previous file with comments | « tools/telemetry/telemetry/results/output_formatter.py ('k') | tools/telemetry/telemetry/results/results_options.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698