Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: tools/telemetry/telemetry/results/csv_page_measurement_results_unittest.py

Issue 416993008: Introduce OutputFormatter interface and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, address review comments. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/csv_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/csv_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/csv_page_measurement_results_unittest.py
deleted file mode 100644
index f49b8668ad702a0a632eec9db6a70497343f0db3..0000000000000000000000000000000000000000
--- a/tools/telemetry/telemetry/results/csv_page_measurement_results_unittest.py
+++ /dev/null
@@ -1,125 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-import StringIO
-import csv
-import os
-import unittest
-
-from telemetry.results import csv_page_measurement_results
-from telemetry.page import page_set
-from telemetry.value import histogram
-from telemetry.value import scalar
-
-
-def _MakePageSet():
- ps = page_set.PageSet(file_path=os.path.dirname(__file__))
- ps.AddPageWithDefaultRunNavigate('http://www.foo.com/')
- ps.AddPageWithDefaultRunNavigate('http://www.bar.com/')
- return ps
-
-class NonPrintingCsvPageMeasurementResults(
- csv_page_measurement_results.CsvPageMeasurementResults):
- def __init__(self, *args):
- super(NonPrintingCsvPageMeasurementResults, self).__init__(*args)
-
- def _PrintPerfResult(self, *args):
- pass
-
-class CsvPageMeasurementResultsTest(unittest.TestCase):
- def setUp(self):
- self._output = StringIO.StringIO()
- self._page_set = _MakePageSet()
-
- @property
- def lines(self):
- lines = StringIO.StringIO(self._output.getvalue()).readlines()
- return lines
-
- @property
- def output_header_row(self):
- rows = list(csv.reader(self.lines))
- return rows[0]
-
- @property
- def output_data_rows(self):
- rows = list(csv.reader(self.lines))
- return rows[1:]
-
- def test_with_no_results_on_second_run(self):
- results = NonPrintingCsvPageMeasurementResults(self._output)
- results.StartTest(self._page_set[0])
- results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
- results.StopTest(self._page_set[0])
-
- results.StartTest(self._page_set[1])
- results.StopTest(self._page_set[1])
-
- results.PrintSummary()
- self.assertEqual(['page_name', 'foo (seconds)'], self.output_header_row)
- # TODO(chrishenry): Is this really the right behavior? Should this
- # not output a second row with '-' as its results?
- expected = [[self._page_set[0].url, '3.0']]
- self.assertEqual(expected, self.output_data_rows)
-
- def test_fewer_results_on_second_run(self):
- results = NonPrintingCsvPageMeasurementResults(self._output)
- results.StartTest(self._page_set[0])
- results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
- results.AddValue(scalar.ScalarValue(self._page_set[0], 'bar', 'seconds', 4))
- results.StopTest(self._page_set[0])
-
- results.StartTest(self._page_set[1])
- results.AddValue(scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 5))
- results.StopTest(self._page_set[1])
-
- results.PrintSummary()
- self.assertEqual(['page_name', 'bar (seconds)', 'foo (seconds)'],
- self.output_header_row)
- expected = [[self._page_set[0].url, '4.0', '3.0'],
- [self._page_set[1].url, '5.0', '-']]
- self.assertEqual(expected, self.output_data_rows)
-
- def test_with_output_at_print_summary_time(self):
- results = NonPrintingCsvPageMeasurementResults(self._output)
- results.StartTest(self._page_set[0])
- results.AddValue(scalar.ScalarValue(self._page_set[0], 'foo', 'seconds', 3))
- results.StopTest(self._page_set[0])
-
- results.StartTest(self._page_set[1])
- results.AddValue(scalar.ScalarValue(self._page_set[1], 'bar', 'seconds', 4))
- results.StopTest(self._page_set[1])
-
- results.PrintSummary()
-
- self.assertEqual(
- self.output_header_row,
- ['page_name', 'bar (seconds)', 'foo (seconds)'])
-
- expected = [[self._page_set[0].display_name, '-', '3.0'],
- [self._page_set[1].display_name, '4.0', '-']]
- self.assertEqual(expected, self.output_data_rows)
-
- def test_histogram(self):
- results = NonPrintingCsvPageMeasurementResults(self._output)
- results.StartTest(self._page_set[0])
- results.AddValue(histogram.HistogramValue(
- self._page_set[0], 'a', '',
- raw_value_json='{"buckets": [{"low": 1, "high": 2, "count": 1}]}'))
- results.StopTest(self._page_set[0])
-
- results.StartTest(self._page_set[1])
- results.AddValue(histogram.HistogramValue(
- self._page_set[1], 'a', '',
- raw_value_json='{"buckets": [{"low": 2, "high": 3, "count": 1}]}'))
- results.StopTest(self._page_set[1])
-
- results.PrintSummary()
-
- self.assertEqual(
- self.output_header_row,
- ['page_name', 'a ()'])
- self.assertEqual(
- self.output_data_rows,
- [[self._page_set[0].display_name, '1.5'],
- [self._page_set[1].display_name, '2.5']])

Powered by Google App Engine
This is Rietveld 408576698