This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called

net/socket/ssl_session_cache_openssl.cc

Index: net/socket/ssl_session_cache_openssl.cc
diff --git a/net/socket/ssl_session_cache_openssl.cc b/net/socket/ssl_session_cache_openssl.cc
index 5bb0d16a31c8383e1d6d5367a01e8e03529789ed..54047bf2cad7360bb00b696c0c9d33cf03ce1b24 100644
--- a/net/socket/ssl_session_cache_openssl.cc
+++ b/net/socket/ssl_session_cache_openssl.cc
@@ -237,7 +237,6 @@ class SSLSessionCacheOpenSSLImpl {
     return SSL_set_session(ssl, session) == 1;
   }
 
-  // Return true iff a cached session was associated with the given |cache_key|.
   bool SSLSessionIsInCache(const std::string& cache_key) const {
     base::AutoLock locked(lock_);
     KeyIndex::const_iterator it = key_index_.find(cache_key);
@@ -253,31 +252,6 @@ class SSLSessionCacheOpenSSLImpl {
     return session_is_good;
   }
 
-  void SetSessionAddedCallback(SSL* ssl, const base::Closure& callback) {
-    // Add |ssl| to the SSLToCallbackMap.
-    ssl_to_callback_map_.insert(SSLToCallbackMap::value_type(
-        ssl, CallbackAndCompletionCount(callback, 0)));
-  }
-
-  // Determines if the session for |ssl| is in the cache, and calls the
-  // appropriate callback if that is the case.
-  //
-  // The session must be both MarkedAsGood and Added in order for the
-  // callback to be run. These two events can occur in either order.
-  void CheckIfSessionFinished(SSL* ssl) {
-    SSLToCallbackMap::iterator it = ssl_to_callback_map_.find(ssl);
-    if (it == ssl_to_callback_map_.end())
-      return;
-    // Increment the session's completion count.
-    if (++it->second.count == 2) {
-      base::Closure callback = it->second.callback;
-      ssl_to_callback_map_.erase(it);
-      callback.Run();
-    }
-  }
-
-  void RemoveSessionAddedCallback(SSL* ssl) { ssl_to_callback_map_.erase(ssl); }
-
   void MarkSSLSessionAsGood(SSL* ssl) {
     SSL_SESSION* session = SSL_get_session(ssl);
     CHECK(session);
@@ -285,8 +259,13 @@ class SSLSessionCacheOpenSSLImpl {
     // Mark the session as good, allowing it to be used for future connections.
     SSL_SESSION_set_ex_data(
         session, GetSSLSessionExIndex(), reinterpret_cast<void*>(1));
+  }
 
-    CheckIfSessionFinished(ssl);
+  bool SessionIsGood(SSL* ssl) {
+    SSL_SESSION* session = SSL_get_session(ssl);
+    CHECK(session);
+    return reinterpret_cast<int64>(

[Ryan Sleevi, 2014/08/06 23:42:03]

BUG: Why do you cast to int64?

Just return SSL_session_get_ex_data(session, ...)

(pointer -> bool conversion is defined - see line 249-252)

[mshelley, 2014/08/07 00:21:59]

Done.

+        SSL_SESSION_get_ex_data(session, GetSSLSessionExIndex()));
   }
 
   // Flush all entries from the cache.
@@ -302,30 +281,12 @@ class SSLSessionCacheOpenSSLImpl {
   }
 
  private:
-  // CallbackAndCompletionCounts are used to group a callback that should be
-  // run when a certain sesssion is added to the session cache with an integer
-  // indicating the status of that session.
-  struct CallbackAndCompletionCount {
-    CallbackAndCompletionCount(const base::Closure& completion_callback,
-                               int completion_count)
-        : callback(completion_callback), count(completion_count) {}
-
-    const base::Closure callback;
-    // |count| < 2 means that the ssl session associated with this object
-    // has not been added to the session cache or has not been marked as good.
-    // |count| is incremented when a session is added to the cache or marked as
-    // good, thus |count| == 2 means that the session is ready for use.
-    int count;
-  };
-
   // Type for list of SSL_SESSION handles, ordered in MRU order.
   typedef std::list<SSL_SESSION*> MRUSessionList;
   // Type for a dictionary from unique cache keys to session list nodes.
   typedef base::hash_map<std::string, MRUSessionList::iterator> KeyIndex;
   // Type for a dictionary from SessionId values to key index nodes.
   typedef base::hash_map<SessionId, KeyIndex::iterator> SessionIdIndex;
-  // Type for a map from SSL* to associated callbacks
-  typedef std::map<SSL*, CallbackAndCompletionCount> SSLToCallbackMap;
 
   // Return the key associated with a given session, or the empty string if
   // none exist. This shall only be used for debugging.
@@ -405,7 +366,6 @@ class SSLSessionCacheOpenSSLImpl {
   static int NewSessionCallbackStatic(SSL* ssl, SSL_SESSION* session) {
     SSLSessionCacheOpenSSLImpl* cache = GetCache(ssl->ctx);
     cache->OnSessionAdded(ssl, session);
-    cache->CheckIfSessionFinished(ssl);
     return 1;
   }
 
@@ -529,7 +489,6 @@ class SSLSessionCacheOpenSSLImpl {
 
   SSL_CTX* ctx_;
   SSLSessionCacheOpenSSL::Config config_;
-  SSLToCallbackMap ssl_to_callback_map_;
 
   // method to get the index which can later be used with SSL_CTX_get_ex_data()
   // or SSL_CTX_set_ex_data().
@@ -568,19 +527,14 @@ bool SSLSessionCacheOpenSSL::SSLSessionIsInCache(
   return impl_->SSLSessionIsInCache(cache_key);
 }
 
-void SSLSessionCacheOpenSSL::RemoveSessionAddedCallback(SSL* ssl) {
-  impl_->RemoveSessionAddedCallback(ssl);
-}
-
-void SSLSessionCacheOpenSSL::SetSessionAddedCallback(SSL* ssl,
-                                                     const base::Closure& cb) {
-  impl_->SetSessionAddedCallback(ssl, cb);
-}
-
 void SSLSessionCacheOpenSSL::MarkSSLSessionAsGood(SSL* ssl) {
   return impl_->MarkSSLSessionAsGood(ssl);
 }
 
+bool SSLSessionCacheOpenSSL::SessionIsGood(SSL* ssl) {
+  return impl_->SessionIsGood(ssl);
+}
+
 void SSLSessionCacheOpenSSL::Flush() { impl_->Flush(); }
 
 }  // namespace net