Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: net/socket/ssl_session_cache_openssl.h

Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r2
Patch Set: Added SessionIsGood method to replace completion count when checking if a session is finished. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_session_cache_openssl.h
diff --git a/net/socket/ssl_session_cache_openssl.h b/net/socket/ssl_session_cache_openssl.h
index 00f93e1949539a9540d444083673c5e6dd321303..ffc1e807bbe38385d75a573760b662103649cf1c 100644
--- a/net/socket/ssl_session_cache_openssl.h
+++ b/net/socket/ssl_session_cache_openssl.h
@@ -117,13 +117,6 @@ class NET_EXPORT SSLSessionCacheOpenSSL {
// Return true iff a cached session was associated with the given |cache_key|.
bool SSLSessionIsInCache(const std::string& cache_key) const;
- // Informs the cache that it should run a callback when |ssl|'s session is
- // added to the cache.
- void SetSessionAddedCallback(SSL* ssl, const base::Closure& callback);
-
- // Removes the entry for |ssl| from cache's callback map.
- void RemoveSessionAddedCallback(SSL* ssl);
-
// Indicates that the SSL session associated with |ssl| is "good" - that is,
// that all associated cryptographic parameters that were negotiated,
// including the peer's certificate, were successfully validated. Because
@@ -132,6 +125,10 @@ class NET_EXPORT SSLSessionCacheOpenSSL {
// only validated sessions are resumed.
void MarkSSLSessionAsGood(SSL* ssl);
+ // Returns true if the SSL session associated with |ssl| has been marked as
+ // good.
+ bool SessionIsGood(SSL* ssl);
+
// Flush removes all entries from the cache. This is typically called when
// the system's certificate store has changed.
void Flush();

Powered by Google App Engine
This is Rietveld 408576698