net/test/spawned_test_server/base_test_server.h - Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/spawned_test_server/base_test_server.h

Issue 416683002: This CL corrects a bug in which the OnHandshakeComplete callback for an ssl session was never called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@r2

Patch Set: Added SessionIsGood method to replace completion count when checking if a session is finished. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/socket/ssl_session_cache_openssl.cc ('K') | « net/socket/ssl_session_cache_openssl.cc ('k') | net/test/spawned_test_server/base_test_server.cc » ('j') | net/tools/testserver/testserver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/test/spawned_test_server/base_test_server.h

diff --git a/net/test/spawned_test_server/base_test_server.h b/net/test/spawned_test_server/base_test_server.h

index 6dd67db3038a186d192e2e8baee4bf509c9aded8..fb71222499c9761b060a9abd5b53400cf15a44ab 100644

--- a/net/test/spawned_test_server/base_test_server.h

+++ b/net/test/spawned_test_server/base_test_server.h

@@ -203,6 +203,10 @@ class BaseTestServer {

// Whether to enable NPN support.

bool enable_npn;

+ // Whether to disable TLS session caching. When session caching is

+ // disabled, the server will generate a new Session ID for every connection.

+ bool disable_session_cache;

};

// Pass as the 'host' parameter during construction to server on 127.0.0.1