Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Tools/GardeningServer/ui/ct-test-list.html

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <polymer-element name="ct-test-list" attributes="tests"> 7 <polymer-element name="ct-test-list" attributes="tests">
8 <template> 8 <template>
9 <style> 9 <style>
10 :host { 10 :host {
11 display: block; 11 display: block;
12 } 12 }
13 </style> 13 </style>
14 <template repeat="{{testName in tests}}"> 14 <template repeat="{{ test in tests }}">
15 <div><a href="{{testName|flakinessDashboardURL}}">{{testName}}</a></div> 15 <!-- FIXME: Find a less redundant UI than repeating the step on each line. -->
16 <div>
17 {{ test.step }}
18 <template if="{{ test.testName }}"><a href="{{ test | flakinessDashboard URL }}">{{ test.testName }}</a></template>
19 <template if="{{ !test.testName }}"><b>whole step failed</b></template>
20 </div>
16 </template> 21 </template>
17 </template> 22 </template>
18 <script> 23 <script>
19 Polymer({ 24 Polymer({
20 flakinessDashboardURL: function(testName) { 25 flakinessDashboardURL: function(test) {
21 return ui.urlForFlakinessDashboard([testName]); 26 return ui.urlForFlakinessDashboard(test.testName, test.step);
22 }, 27 },
23 }); 28 });
24 </script> 29 </script>
25 </polymer-element> 30 </polymer-element>
OLDNEW
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-panel-tests.html ('k') | Tools/GardeningServer/ui/ct-test-list-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698