Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3563)

Unified Diff: Tools/GardeningServer/scripts/ui.js

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/scripts/ui_unittests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/ui.js
diff --git a/Tools/GardeningServer/scripts/ui.js b/Tools/GardeningServer/scripts/ui.js
index f511e8a38c4f58789f0dc53314269cc16f3494c7..5b2701fe5ede208427e0854d0d0d4c43b69ed799 100644
--- a/Tools/GardeningServer/scripts/ui.js
+++ b/Tools/GardeningServer/scripts/ui.js
@@ -34,15 +34,27 @@ ui.displayNameForBuilder = function(builderName)
return builderName.replace(/Webkit /i, '');
}
-ui.urlForFlakinessDashboard = function(opt_testNameList)
+// FIXME: Take a master name argument as well.
+ui.urlForFlakinessDashboard = function(testNames, testType)
{
- var testsParameter = opt_testNameList ? opt_testNameList.join(',') : '';
- return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=' + encodeURIComponent(testsParameter);
+ if (Array.isArray(testNames))
+ testNames = testNames.join(',');
+
+ // FIXME: Remove this once the flakiness dashboard stops having webkit_tests
+ // masquerade as layout-tests.
+ if (testType == 'webkit_tests')
+ testType = 'layout-tests';
+
+ return 'http://test-results.appspot.com/dashboards/flakiness_dashboard.html#' +
+ Object.toQueryString({
+ tests: testNames,
+ testType: testType,
+ });
}
-ui.urlForEmbeddedFlakinessDashboard = function(opt_testNameList)
+ui.urlForEmbeddedFlakinessDashboard = function(testNames, testType)
{
- return ui.urlForFlakinessDashboard(opt_testNameList) + '&showChrome=false';
+ return ui.urlForFlakinessDashboard(testNames, testType) + '&showChrome=false';
}
})();
« no previous file with comments | « Tools/GardeningServer/run-unittests.html ('k') | Tools/GardeningServer/scripts/ui_unittests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698