Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 415423002: Remove Create*Value (except CreateNullValue) (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
asanka, SteveT, benwells, Nico, zel
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove Create*Value (except CreateNullValue) BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -49 lines) Patch
M base/values.h View 1 chunk +0 lines, -7 lines 0 comments Download
M base/values.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/download/download_query.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_service_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/default_search_pref_test_util.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/value_store/value_store_frontend_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
asanka: chrome/browser/download/download_query.h net/test/spawned_test_server/base_test_server.cc benwells: extensions/browser/value_store/value_store_frontend_unittest.cc stevet: components/search_engines/default_search_pref_test_util.cc thakis: base/values.cc base/values.h chrome/browser/download/download_query.h zelidrag: chromeos/dbus/shill_ipconfig_client_unittest.cc chromeos/dbus/shill_service_client_unittest.cc
6 years, 5 months ago (2014-07-24 23:29:08 UTC) #1
Nico
lgtm (accidentally looked at everything)
6 years, 5 months ago (2014-07-24 23:32:49 UTC) #2
asanka
lgtm
6 years, 5 months ago (2014-07-24 23:38:18 UTC) #3
benwells
lgtm
6 years, 5 months ago (2014-07-25 00:31:00 UTC) #4
zel
lgtm
6 years, 5 months ago (2014-07-25 00:55:42 UTC) #5
SteveT
lgtm
6 years, 5 months ago (2014-07-25 01:03:42 UTC) #6
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-25 01:54:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/415423002/1
6 years, 5 months ago (2014-07-25 02:25:58 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 05:55:42 UTC) #9
Message was sent while issue was closed. 
Change committed as 285496

Powered by Google App Engine
This is Rietveld 408576698