Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: components/search_engines/default_search_pref_test_util.cc

Issue 415423002: Remove Create*Value (except CreateNullValue) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/default_search_pref_test_util.cc
diff --git a/components/search_engines/default_search_pref_test_util.cc b/components/search_engines/default_search_pref_test_util.cc
index f3041b67399428d7e8d2b54f47d2cf72834c88a9..f09add350e453ab208a1025dd0d07d43a732422b 100644
--- a/components/search_engines/default_search_pref_test_util.cc
+++ b/components/search_engines/default_search_pref_test_util.cc
@@ -29,17 +29,17 @@ DefaultSearchPrefTestUtil::CreateDefaultSearchPreferenceValue(
EXPECT_FALSE(keyword.empty());
EXPECT_FALSE(search_url.empty());
value->Set(DefaultSearchManager::kShortName,
- base::Value::CreateStringValue(name));
+ new base::StringValue(name));
value->Set(DefaultSearchManager::kKeyword,
- base::Value::CreateStringValue(keyword));
+ new base::StringValue(keyword));
value->Set(DefaultSearchManager::kURL,
- base::Value::CreateStringValue(search_url));
+ new base::StringValue(search_url));
value->Set(DefaultSearchManager::kSuggestionsURL,
- base::Value::CreateStringValue(suggest_url));
+ new base::StringValue(suggest_url));
value->Set(DefaultSearchManager::kFaviconURL,
- base::Value::CreateStringValue(icon_url));
+ new base::StringValue(icon_url));
value->Set(DefaultSearchManager::kSearchTermsReplacementKey,
- base::Value::CreateStringValue(search_terms_replacement_key));
+ new base::StringValue(search_terms_replacement_key));
std::vector<std::string> encodings_items;
base::SplitString(encodings, ';', &encodings_items);
@@ -53,7 +53,7 @@ DefaultSearchPrefTestUtil::CreateDefaultSearchPreferenceValue(
scoped_ptr<base::ListValue> alternate_url_list(new base::ListValue());
if (!alternate_url.empty())
- alternate_url_list->Append(base::Value::CreateStringValue(alternate_url));
+ alternate_url_list->Append(new base::StringValue(alternate_url));
value->Set(DefaultSearchManager::kAlternateURLs,
alternate_url_list.release());
return value.Pass();
« no previous file with comments | « chromeos/dbus/shill_service_client_unittest.cc ('k') | extensions/browser/value_store/value_store_frontend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698