Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2935)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/values.h

Issue 415423002: Remove Create*Value (except CreateNullValue) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index c478e3ac79e199ca4a79540ac29a59850789f632..d5e631310319f2476b5fe80eabeb96ec9b88a0da 100644
--- a/base/values.h
+++ b/base/values.h
@@ -64,13 +64,6 @@ class BASE_EXPORT Value {
virtual ~Value();
static Value* CreateNullValue();
- // DEPRECATED: Do not use the following 5 functions. Instead, use
- // new FundamentalValue or new StringValue.
- static FundamentalValue* CreateBooleanValue(bool in_value);
- static FundamentalValue* CreateIntegerValue(int in_value);
- static FundamentalValue* CreateDoubleValue(double in_value);
- static StringValue* CreateStringValue(const std::string& in_value);
- static StringValue* CreateStringValue(const string16& in_value);
// Returns the type of the value stored by the current Value object.
// Each type will be implemented by only one subclass of Value, so it's
« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698