Source/core/rendering/RenderMenuList.cpp - Issue 415343003: Option Groups with display: none should not show the children option elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderMenuList.cpp

Issue 415343003: Option Groups with display: none should not show the children option elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed assert failure in linux dbg build Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderMenuList.cpp

diff --git a/Source/core/rendering/RenderMenuList.cpp b/Source/core/rendering/RenderMenuList.cpp

index 57ac3b845c3a872b4546cb08d9fab7f77e7551d6..adcb5f707767688e2eee60ec4c8039359fc7e3ac 100644

--- a/Source/core/rendering/RenderMenuList.cpp

+++ b/Source/core/rendering/RenderMenuList.cpp

@@ -503,7 +503,8 @@ PopupMenuStyle RenderMenuList::itemStyle(unsigned listIndex) const

RenderStyle* style = element->renderStyle() ? element->renderStyle() : element->computedStyle();

return style ? PopupMenuStyle(resolveColor(style, CSSPropertyColor), itemBackgroundColor, style->font(), style->visibility() == VISIBLE,

- style->display() == NONE, style->textIndent(), style->direction(), isOverride(style->unicodeBidi()),

+ isHTMLOptionElement(*element) ? toHTMLOptionElement(*element).isDisplayNone() : style->display() == NONE,

+ style->textIndent(), style->direction(), isOverride(style->unicodeBidi()),

itemHasCustomBackgroundColor ? PopupMenuStyle::CustomBackgroundColor : PopupMenuStyle::DefaultBackgroundColor) : menuStyle();

}

« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/web/ExternalPopupMenu.h » ('j') | no next file with comments »